Merged
Conversation
Member
LlamaLad7
commented
Dec 23, 2025
LlamaLad7
commented
- Fixes not being to reference fields of Mixin inner classes
- Removes the special case for synthetic inner classes (usually switch maps) since it's unneeded and sometimes incorrect
- Supports arbitrarily nested inner classes
This was a very strange exception to have in the first place, and the default path works fine. Notably, you are also allowed to have enums inside Mixins, in which case those would be given different names for each target class and therefore any switch tables referencing them are *not* safe to share.
Player3324
approved these changes
Dec 25, 2025
SettingDust
reviewed
Dec 29, 2025
src/main/java/org/spongepowered/asm/mixin/transformer/InnerClassGenerator.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.